-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal: Renamed "settings_current" table to just "settings" - refs #5567 #5572
Conversation
Code Climate has analyzed commit bf239c3 and detected 29 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Bueno... técnicamente no era necesario renombrar la constante TABLE_MAIN_SETTINGS_CURRENT (justamente para eso usamos una constante, para no tener luego que cambiar el texto por todos lados), solo su valor, pero ahora que está hecho, déjalo así. |
When I try to execute the migration, I get a "create" and a "drop" table, not a rename, so all settings would be lost:
Maybe testing it we realise that the --dump-sql command is badly documented and it replaces the table, but for what I see this is not the case. |
Otherwise this PR is OK. |
The migration can be applied (on existing development systems) with: |
No description provided.